Record performance re-audit results for multispectral#1418
Open
brendancol wants to merge 1 commit intomainfrom
Open
Record performance re-audit results for multispectral#1418brendancol wants to merge 1 commit intomainfrom
brendancol wants to merge 1 commit intomainfrom
Conversation
Re-audited multispectral after PRs 1292 (true_color memory guard) and 1301 (validate_arrays in true_color). Verdict remains SAFE / compute- bound, no HIGH findings. Notes: - MEDIUM: _true_color_dask and _true_color_dask_cupy use da.stack on the band axis without rechunk, producing chunks of size 1 along that axis. With 4 bands the impact is scheduling overhead only. - LOW: _true_color_numpy allocates np.zeros((h,w,4)) before fully overwriting all four channels; np.empty would suffice. - All 17 index functions use plain map_blocks with no halo. An 8192x8192 ndvi graph is 80 tasks, evi/arvi/ebbi 112 tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/sweep-performance-state.csvrow for multispectral with the new inspection date and notes from this pass.Notes recorded
_true_color_daskand_true_color_dask_cupyuseda.stackon the band axis withoutrechunk, producing chunks of size 1 along that axis. With 4 bands the impact is scheduling overhead only._true_color_numpyallocatesnp.zeros((h, w, 4))before fully overwriting all four channels;np.emptywould suffice.map_blockswith no halo. An 8192x8192 ndvi graph is 80 tasks; evi/arvi/ebbi 112 tasks.Test plan
csv.DictReader/DictWriter./tmp/multispectral_graph_1.pybuilds (never computes) ndvi/evi/arvi/msavi2/savi/ebbi/true_color graphs and reports linear task counts.