Skip to content

Update behat-data URLs in tests #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Apr 30, 2026
Merged

Update behat-data URLs in tests #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions features/export.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,15 +918,15 @@ Feature: Export content.
Then STDOUT should be a number
And save STDOUT as {EXPORT_ATTACHMENT_POST_ID}

When I run `wp media import 'http://wp-cli.org/behat-data/codeispoetry.png' --post_id={EXPORT_ATTACHMENT_POST_ID} --porcelain`
When I run `wp media import 'http://wp-cli.github.io/behat-data/codeispoetry.png' --post_id={EXPORT_ATTACHMENT_POST_ID} --porcelain`
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use https instead of http for the asset URL. GitHub Pages supports and often enforces HTTPS, so using it directly avoids unnecessary redirects and provides a more secure connection for downloading test assets.

    When I run `wp media import 'https://wp-cli.github.io/behat-data/codeispoetry.png' --post_id={EXPORT_ATTACHMENT_POST_ID} --porcelain`

Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https:// for the GitHub Pages behat-data URLs. GitHub Pages will typically redirect http to https, which adds an extra request and can fail in environments that block insecure HTTP or redirects.

Copilot uses AI. Check for mistakes.
Then STDOUT should be a number
And save STDOUT as {EXPORT_ATTACHMENT_ID}

When I run `wp post create --post_title='Post with attachment to ignore' --porcelain`
Then STDOUT should be a number
And save STDOUT as {IGNORE_ATTACHMENT_POST_ID}

When I run `wp media import 'http://wp-cli.org/behat-data/white-150-square.jpg' --post_id={IGNORE_ATTACHMENT_POST_ID} --porcelain`
When I run `wp media import 'http://wp-cli.github.io/behat-data/white-150-square.jpg' --post_id={IGNORE_ATTACHMENT_POST_ID} --porcelain`
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use https instead of http for the asset URL. GitHub Pages supports and often enforces HTTPS, so using it directly avoids unnecessary redirects and provides a more secure connection for downloading test assets.

    When I run `wp media import 'https://wp-cli.github.io/behat-data/white-150-square.jpg' --post_id={IGNORE_ATTACHMENT_POST_ID} --porcelain`

Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https:// for the GitHub Pages behat-data URLs. Using http relies on redirects and makes the test dependent on insecure HTTP being allowed.

Copilot uses AI. Check for mistakes.
Then STDOUT should be a number
And save STDOUT as {IGNORE_ATTACHMENT_ID}

Expand Down
Loading