feat: android support#1355
Conversation
👷 Deploy Preview for viteplus-preview processing.
|
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d79ad40be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 862095f040
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn platform_string(&self, platform: Platform) -> Str { | ||
| let os = match platform.os { | ||
| Os::Linux => "linux", | ||
| Os::Android => "android", |
There was a problem hiding this comment.
android-* Node artifacts
Setting Os::Android to "android" makes get_download_info build URLs like node-v<ver>-android-arm64.tar.gz, but Node's published dist artifacts are named with linux-*, darwin-*, and win-* prefixes (no android-* entries). On Android hosts that need runtime auto-installation (no system Node available), this change will consistently fetch a non-existent archive and fail runtime setup, so Android support appears enabled but cannot complete installs.
Useful? React with 👍 / 👎.
2 participants
Since vite-task voidzero-dev/vite-task#352 support, this PR is ready.
add android for vite_js_runtime