Merged
Conversation
is_generation_query() only checked the current user input, so short follow-up messages like "sure go ahead fix all then" didn't match any keyword and caused the agent to be built without WriteFileTool, WriteFilesTool, and ShellTool. The model then tried to call those tools (they were in conversation history) and got ToolNotFoundError. Two fixes: 1. Add commonly missing generation verbs to is_generation_query: fix, update, add, change, modify, edit, configure, setup, patch, install - these clearly imply file modification intent. 2. Track last_was_generation in ChatSession. For short inputs (< 60 chars) that aren't planning mode, inherit generation mode from the previous turn so confirmations like "sure", "yes", "go ahead" keep write/shell tools active. Co-Authored-By: Claude <noreply@anthropic.com>
The agent created a hallucinated project_id when deploying for the syncable platform. Instead of relying context, the project_id is now ALWAYS derrived directly from the session, where users attach them selves to a project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.