chore: fix JavaScript lint errors (issue #9110)#11940
Closed
alokchando wants to merge 1 commit intostdlib-js:developfrom
Closed
chore: fix JavaScript lint errors (issue #9110)#11940alokchando wants to merge 1 commit intostdlib-js:developfrom
alokchando wants to merge 1 commit intostdlib-js:developfrom
Conversation
## Description Fixed a `RangeError: Invalid time value` in `dispatch-workflow/lib/query.js` caused by calling `.toISOString()` on an invalid Date object when `info.reset` is undefined or not a valid number. ## Changes - Added `typeof` check to ensure `info.reset` is a number - Stored `getTime()` result in `time` variable - Used `isNaN()` guard before calling `.toISOString()` ## Related Issues resolves stdlib-js#9110 Signed-off-by: alok chando <chandoalok@gmail.com>
stdlib-bot
added
Tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a
RangeError: Invalid time valueindispatch-workflow/lib/query.jscaused by calling.toISOString()on an invalid Date object wheninfo.resetis undefined or not a valid number.Changes
typeofcheck to ensureinfo.resetis a numbergetTime()result intimevariableisNaN()guard before calling.toISOString()Related Issues
resolves #9110
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used ChatGPT to understand the runtime error in
dispatch-workflow/lib/query.jsand to help design a safe validation fix forinfo.resetbefore calling.toISOString(). The final implementation was reviewed and applied manually by myself.@stdlib-js/reviewers