Skip to content

feat: add route and menu support for axis domain-*#11858

Open
gururaj1512 wants to merge 1 commit intostdlib-js:refactor/plotfrom
gururaj1512:view-axis-domain-_
Open

feat: add route and menu support for axis domain-*#11858
gururaj1512 wants to merge 1 commit intostdlib-js:refactor/plotfrom
gururaj1512:view-axis-domain-_

Conversation

@gururaj1512
Copy link
Copy Markdown
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • feat: add route and menu support for axis domain-*
Screen.Recording.2026-04-30.at.2.18.46.PM.mov

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 30, 2026
@gururaj1512
Copy link
Copy Markdown
Member Author

@kgryte, You may see here that domain when set to false is not reflecting the changes. Seems like a bug — I tried to identify the cause but couldn't find it. Needs to be resolved.

@gururaj1512
Copy link
Copy Markdown
Member Author

gururaj1512 commented May 1, 2026

Since the domain property in Vega axes is defined as a static boolean, it behaves as an initialization-time configuration rather than a reactive one.

To address this limitation, a practical workaround is to dynamically set domainOpacity to 0 whenever domain is set to false. This approach ensures the UI behaves smoothly and aligns with expected visual outcomes.

Demo:

Screen.Recording.2026-05-01.at.9.03.36.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants