Serialise packets into a buffer#1792
Merged
Rob-Hague merged 1 commit intosshnet:developfrom May 5, 2026
Merged
Conversation
WojciechNagorski
approved these changes
May 5, 2026
A byte array is allocated to hold each plaintext packet. This removes that by adding a buffer for that purpose.
Rob-Hague
commented
May 5, 2026
Comment on lines
1079
to
+1081
| lock (_socketWriteLock) | ||
| { | ||
| var activeBufferLength = message.GetPacket( |
Collaborator
Author
There was a problem hiding this comment.
for posterity: I measured and did not see any increased lock contention from moving GetPacket inside the lock. Most parallel scenarios are already made serial by the lock in Channel.SendData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A byte array is allocated to hold each plaintext packet. This removes that by adding
a buffer for that purpose.
This is the last per-byte-sent allocation between the SSH channel layer and the socket transport. There remains one more in the SFTP layer.
Based on #1788, this change is the third commit