Port SQLCDEBUG to a registry-style package modeled after Go's GODEBUG#4420
Merged
kyleconroy merged 1 commit intomainfrom Apr 30, 2026
Merged
Port SQLCDEBUG to a registry-style package modeled after Go's GODEBUG#4420kyleconroy merged 1 commit intomainfrom
kyleconroy merged 1 commit intomainfrom
Conversation
Replace the monolithic opts.Debug snapshot with internal/sqlcdebug, which
exposes a master Settings table and per-call-site Setting handles via
sqlcdebug.New("name"). Each consumer reads its setting independently
through Setting.Value(), removing the need to thread a Debug struct
through cmd.Env, opts.Parser, and the analyzer constructors.
Migrated readers:
- cmd: trace, processplugins, dumpcatalog, dumpvetenv, dumpexplain, databases
- compiler: dumpast
- postgresql/sqlite analyzers: databases
- tracer: trace (now via tracer.Path())
The endtoend test fixture process_plugin_disabled now installs the
SQLCDEBUG override via sqlcdebug.Update for the duration of the subtest;
TestReplay subtests run sequentially, so no synchronization is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the monolithic opts.Debug snapshot with internal/sqlcdebug, which
exposes a master Settings table and per-call-site Setting handles via
sqlcdebug.New("name"). Each consumer reads its setting independently
through Setting.Value(), removing the need to thread a Debug struct
through cmd.Env, opts.Parser, and the analyzer constructors.
Migrated readers:
The endtoend test fixture process_plugin_disabled now installs the
SQLCDEBUG override via sqlcdebug.Update for the duration of the subtest;
TestReplay subtests run sequentially, so no synchronization is needed.