Conversation
Release notes cover: - NATS JetStream consumer configuration improvements - Queue name validation for NATS backend - QueueType multi-backend architecture - Enhanced public API documentation - Bug fixes and maintenance updates Assisted-By: Claude Code
Restructured release notes to highlight NATS JetStream as the major feature of 4.0.0-RC4: - Added NATS backend as primary feature announcement - Included backend comparison table - Added migration guide for opt-in NATS support - Clarified backward compatibility with 3.x - Updated roadmap to focus on NATS GA and ecosystem Assisted-By: Claude Code
…package Move backend-agnostic service interface definitions to rqueue-core/src/main/java/com/github/sonus21/rqueue/web/, eliminating unnecessary coupling between backend implementations (rqueue-redis, rqueue-nats) and the dashboard layer (rqueue-web). Service interfaces moved: - RqueueSystemManagerService - RqueueQDetailService - RqueueJobService - RqueueDashboardChartService - RqueueViewControllerService - RqueueJobMetricsAggregatorService The interfaces are now in rqueue-core's web package, allowing backend modules to depend only on rqueue-core instead of the full web layer. The rqueue-web module continues to depend on rqueue-core and hosts the implementations (in the .service.impl package). This architectural refactoring aligns with the multi-backend SPI framework by ensuring backend implementations are independent of UI layers. Spring integration modules (rqueue-spring, rqueue-spring-boot-starter) continue to depend on rqueue-web for controller and template resources. Assisted-By: Claude Code
…and rqueue-web Move backend-agnostic service interfaces to rqueue-core, ensuring clean separation between core abstractions and the dashboard UI layer: **Service Interfaces Relocated:** - Dashboard services → rqueue-core/src/main/java/com/github/sonus21/rqueue/web/ - RqueueSystemManagerService - RqueueQDetailService - RqueueJobService - RqueueDashboardChartService - RqueueViewControllerService - Metrics service → rqueue-core/src/main/java/com/github/sonus21/rqueue/metrics/ - RqueueMetricsAggregatorService (renamed from RqueueJobMetricsAggregatorService) **Package Organization Improvements:** - Move Pebble template functions from rqueue-web/utils/pebble/ to rqueue-web/web/pebble/ - DateTimeFunction, DeadLetterQueuesFunction, DefaultFunction, DurationFunction - ReadableDateTimeFunction, ResourceLoader, RqueuePebbleExtension - Aligns template utilities with web package structure **Impact:** - Backend modules (rqueue-redis, rqueue-nats) now depend only on rqueue-core - rqueue-web continues to depend on rqueue-core and hosts service implementations - Spring integration modules (rqueue-spring, rqueue-spring-boot-starter) keep rqueue-web dependency - Improved package organization with utilities co-located with the packages they serve Assisted-By: Claude Code
Clean up duplicate RqueueJobMetricsAggregatorService from rqueue-web/src/main/java after moving the interface to rqueue-core/metrics as RqueueMetricsAggregatorService. Move the test RqueueTaskMetricsAggregatorServiceTest from rqueue-web to rqueue-core/src/test/java/com/github/sonus21/rqueue/metrics/, updating package declarations and class references to use the renamed RqueueMetricsAggregatorService. This ensures a single source of truth for the metrics aggregator interface in the core module. Assisted-By: Claude Code
Remove duplicate service interface definitions from rqueue-web/src/main/java/com/github/sonus21/rqueue/web/service/ since they now live in rqueue-core: - RqueueDashboardChartService - RqueueJobService - RqueueQDetailService - RqueueSystemManagerService - RqueueViewControllerService The implementation classes in rqueue-web/service/impl remain unchanged, now implementing interfaces from rqueue-core. This completes the architectural refactoring with a single source of truth for service interfaces in rqueue-core. Assisted-By: Claude Code
Delete RELEASE_NOTES.md - release notes will be managed elsewhere. Assisted-By: Claude Code
Add imports for service interfaces that were moved from rqueue-web to rqueue-core/web package: - RqueueDashboardChartService - RqueueJobService - RqueueQDetailService - RqueueSystemManagerService - RqueueViewControllerService Update test files in rqueue-web/src/test/java to import these interfaces from rqueue-core.web instead of local package. Assisted-By: Claude Code
Add imports for service interfaces that were moved from rqueue-web to rqueue-core/web package in test files that reference them: - RqueueDashboardChartService - RqueueJobService - RqueueQDetailService - RqueueSystemManagerService - RqueueViewControllerService Update test files in rqueue-web/src/test/java to import these interfaces from rqueue-core.web instead of local package. Assisted-By: Claude Code
Add Coveralls step to CI workflow to push JaCoCo coverage reports. This was missing from the coverage_report job, causing coverage data to not be uploaded to Coveralls. The step downloads merged coverage report and pushes it to Coveralls using the GitHub token. Assisted-By: Claude Code
- Only run coverallsJacoco if COVERALLS_REPO_TOKEN is set - Add --info flag for detailed logging to diagnose issues Assisted-By: Claude Code
Ensures the build fails if the token is missing so we can diagnose why coverage is not being sent to Coveralls. Assisted-By: Claude Code
Log coveralls requests and errors to diagnose why coverage is not being sent. Assisted-By: Claude Code
Provide CI metadata (CI_NAME, CI_BUILD_NUMBER, CI_BRANCH, etc.) so the coveralls plugin can properly identify the build context and send coverage data with correct metadata to Coveralls API. Assisted-By: Claude Code
Write coveralls request JSON to file for debugging and display it in CI logs so we can see exactly what data is being sent to Coveralls API. Assisted-By: Claude Code
The nbaztec coveralls-jacoco plugin auto-detects GitHub Actions and parses PR/branch info from GitHub's environment variables. Only need to set CI_BRANCH since GitHub_ACTIONS and GITHUB_TOKEN are auto-provided. Assisted-By: Claude Code
For GitHub Actions pull requests, github.ref_name returns the PR reference (e.g., "293/merge") instead of the actual branch name. The coveralls-jacoco plugin uses CI_BRANCH to identify the branch in coverage reports. By using github.head_ref (which provides the branch name for PRs) with github.ref_name as a fallback (for push events), we ensure the correct branch is reported. Assisted-By: Claude Code
The nbaztec coveralls-jacoco v1.2.20 plugin has a quirky GitHub Actions
detection path. Reading its source (ServiceInfoParser.kt):
- If GITHUB_ACTIONS is set but GITHUB_TOKEN is not, it emits
service_name="github-actions" — which the Coveralls API does not
recognize as a first-class service, so PR comments and branch
correlation silently no-op.
- When BOTH GITHUB_ACTIONS and GITHUB_TOKEN are set, it switches to
service_name="github" (the canonical name).
- service_job_id is read from BUILD_NUMBER (Jenkins-style), not
GITHUB_RUN_ID — so we map github.run_id onto BUILD_NUMBER explicitly.
- Branch is read from CI_BRANCH; github.head_ref is used so PR builds
report the source branch instead of "<num>/merge".
Verified locally by running coverallsJacoco with the production token
plus a CircleCI-shaped env block (the plugin's CircleCI branch is the
best-supported one) — Coveralls returned OK and the build appeared in
the dashboard.
Also re-adds coverallsRequest = file(...) so the request payload is
written to build/coveralls-request.json. The workflow's "Push coverage
to Coveralls" step already cats this file, which makes future
regressions diagnosable from the CI log alone.
Assisted-By: Claude Code
Coverage Report for CI Build 0Warning No base build found for commit Coverage: 51.631%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: