fix(sync): (Codex) Dropbox exists swallows auth errors#1394
Open
cyfung1031 wants to merge 1 commit intomainfrom
Open
fix(sync): (Codex) Dropbox exists swallows auth errors#1394cyfung1031 wants to merge 1 commit intomainfrom
cyfung1031 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exists()现在只把 Dropbox 明确返回的「路径不存在」视为false;如果是认证失败、网络错误、服务端错误等异常,会继续抛出,不再被误判成文件不存在。这样DropboxFileWriter.write()不会在 token 失效或网络异常时错误地走“创建新文件”逻辑。isDropboxPathNotFound(),统一判断 Dropbox 的path/not_found/path_lookup/not_found。exists()的路径不存在与 auth error 回归测试。