Fix NoMethodError in CallBaseNode#modified_vars for anonymous rest#447
Open
Fix NoMethodError in CallBaseNode#modified_vars for anonymous rest#447
Conversation
Since ff8a516, anonymous rest arguments (bare `*`) are represented as `nil` placeholders in `@positional_args` instead of `DummyNilNode`. However, `CallBaseNode#modified_vars` iterates the positional args array without skipping nil, raising NoMethodError when a call with anonymous rest forwarding appears inside a branch (e.g. `if cond; bar(*); end`) whose `modified_vars` is walked from `BranchNode#install0`. Use safe navigation so nil placeholders are skipped, matching how `each_subnode` already guards against nil subnodes. Add a regression case to scenario/args/anonymous_rest.rb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ff8a516, anonymous rest arguments (bare
*) are represented asnilplaceholders in@positional_argsinstead ofDummyNilNode.However,
CallBaseNode#modified_varsiterates the positional argsarray without skipping nil, raising NoMethodError when a call with
anonymous rest forwarding appears inside a branch (e.g.
if cond; bar(*); end) whosemodified_varsis walked fromBranchNode#install0.Use safe navigation so nil placeholders are skipped, matching how
each_subnodealready guards against nil subnodes. Add a regressioncase to scenario/args/anonymous_rest.rb.