Skip to content

Fix rewatch warning replay after early compile errors#8408

Draft
cknitt wants to merge 2 commits intomasterfrom
codex/fix-rewatch-warning-replay
Draft

Fix rewatch warning replay after early compile errors#8408
cknitt wants to merge 2 commits intomasterfrom
codex/fix-rewatch-warning-replay

Conversation

@cknitt
Copy link
Copy Markdown
Member

@cknitt cknitt commented May 4, 2026

Summary

Fixes a rewatch scheduler edge case where stored compiler warnings could disappear after an early compile error.

The DAG scheduler can stop dispatching new work once a module fails. Some modules may be part of the compile universe but never actually recompile. Previously, warning replay skipped every module in the compile universe, so warnings stored on those skipped modules were not emitted. This could make snapshot output depend on scheduling order.

Changes

  • Track modules that actually recompiled instead of using the full compile universe.
  • Preserve stored warning state for clean, non-recompiled completions.
  • Replay stored warnings for modules that did not actually recompile.
  • Extract the replay logic into a helper.
  • Add focused regression tests for skipped-module warning replay.

cknitt added 2 commits May 4, 2026 08:39
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 4, 2026

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8408

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8408

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8408

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8408

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8408

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8408

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8408

commit: a3eb179

@cknitt cknitt requested review from fhammerschmidt and removed request for fhammerschmidt May 4, 2026 11:09
@cknitt cknitt marked this pull request as draft May 4, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant