Skip to content

docs: Remove unused onAddTask prop and useContext imports from reducer + context example#8427

Open
danrday wants to merge 1 commit intoreactjs:mainfrom
danrday:fix-unused-onaddtask-prop
Open

docs: Remove unused onAddTask prop and useContext imports from reducer + context example#8427
danrday wants to merge 1 commit intoreactjs:mainfrom
danrday:fix-unused-onaddtask-prop

Conversation

@danrday
Copy link
Copy Markdown

@danrday danrday commented May 3, 2026

AddTask no longer needs an onAddTask prop or useContext now that the component reads dispatch directly from context via useTasksDispatch.

  • Removes the onAddTask prop from AddTask - the component uses
    useTasksDispatch() directly, so no handler needs to be passed down
  • Removes the unused useContext import from both AddTask.js and
    TaskList.js - the custom hooks (useTasksDispatch, useTasks)
    already encapsulate the context calls

No behavior change. This makes the example consistent with the
surrounding explanation, which highlights that context lets child
components skip prop-passing entirely.

AddTask no longer needs an onAddTask prop or useContext now that the
component reads dispatch directly from context via useTasksDispatch.
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 3, 2026

Hi @danrday!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@danrday danrday changed the title Reducer + Context example: Remove unused onAddTask prop and useContext imports docs: Remove unused onAddTask prop and useContext imports from reducer + context example May 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 3, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant