gh-139489: Add xml.is_valid_text()#149412
Open
serhiy-storchaka wants to merge 2 commits intopython:mainfrom
Open
gh-139489: Add xml.is_valid_text()#149412serhiy-storchaka wants to merge 2 commits intopython:mainfrom
serhiy-storchaka wants to merge 2 commits intopython:mainfrom
Conversation
Documentation build overview
10 files changed ·
|
Member
|
What do you think of adding also a sanitize function which takes a callback? Example: import re
ILLEGAL_XML_CHARS_RE = re.compile(
'['
# Control characters; newline (\x0A and \x0D) and TAB (\x09) are legal
'\x00-\x08\x0B\x0C\x0E-\x1F'
# Surrogate characters
'\uD800-\uDFFF'
# Special Unicode characters
'\uFFFE'
'\uFFFF'
# Match multiple sequential invalid characters for better efficiency
']+')
def sanitize(text, replace_func):
def callback(regs):
return replace_func(regs[0])
return ILLEGAL_XML_CHARS_RE.sub(callback, text)
def escape(text):
return ''.join(f'\\x{ord(char):02x}' for char in text)
invalid = '\x00'
test = f'a{invalid}b'
print(sanitize(test, lambda text: '#' * len(text)))
print(sanitize(test, escape))It would be useful for |
serhiy-storchaka
commented
May 5, 2026
Co-authored-by: Stan Ulbrych <stan@python.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Member
Author
I left it for a separate PR. I have similar function in a different branch. But it accepts also the name of the registered error handler ('strict', 'ignore', 'replace, 'backslashreplace', etc) and the callback has different interface. It needs a separate discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.