Skip to content

gh-148874: add flag to CALL to skip periodic check in with #149019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NekoAsakura wants to merge 9 commits into
base: main
Choose a base branch
from
Open

gh-148874: add flag to CALL to skip periodic check in with #149019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
34535ba
gh-148874: add flag to `CALL` to skip periodic check in `with`
NekoAsakura Apr 24, 2026
cceb8db
fixup
NekoAsakura Apr 26, 2026
6a07b77
Merge branch 'main' into gh-148874/with-signal-exit-skip
NekoAsakura Apr 26, 2026
658c05f
address review feedback
NekoAsakura Apr 28, 2026
0237f8e
Merge branch 'main' into gh-148874/with-signal-exit-skip
NekoAsakura Apr 28, 2026
7262c62
Merge branch 'main' into gh-148874/with-signal-exit-skip
NekoAsakura Apr 29, 2026
40fc50c
Update Doc/library/dis.rst
NekoAsakura Apr 30, 2026
8fc75f0
Merge branch 'main' into gh-148874/with-signal-exit-skip
NekoAsakura May 2, 2026
e8e3d32
Merge branch 'main' into gh-148874/with-signal-exit-skip
NekoAsakura May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Doc/library/dis.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ the following command can be used to display the disassembly of
<BLANKLINE>
3 LOAD_GLOBAL 1 (len + NULL)
LOAD_FAST_BORROW 0 (alist)
CALL 1
CALL 3 (1)
RETURN_VALUE

(The "2" is a line number).
Expand Down Expand Up @@ -1601,6 +1601,10 @@ iterations of the loop.
.. versionchanged:: 3.13
Calls with keyword arguments are now handled by :opcode:`CALL_KW`.

.. versionchanged:: next
``argc`` is now the oparg shifted right by one. The low bit indicates
that no interrupt check is made after the call


.. opcode:: CALL_KW (argc)

Expand Down
3 changes: 2 additions & 1 deletion Include/internal/pycore_magic_number.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ Known values:
Python 3.15a8 3663 (Merge GET_ITER and GET_YIELD_FROM_ITER. Modify SEND to make it a bit more like FOR_ITER)
Python 3.15a8 3664 (Fix __qualname__ for __annotate__ functions)
Python 3.15a8 3665 (Add FOR_ITER_VIRTUAL and GET_ITER specializations)
Python 3.15a9 3666 (Pack CALL oparg as (argcount<<1) | interruptible; gh-148874)


Python 3.16 will start with 3700
Expand All @@ -309,7 +310,7 @@ PC/launcher.c must also be updated.

*/

#define PYC_MAGIC_NUMBER 3665
#define PYC_MAGIC_NUMBER 3666
Copy link
Copy Markdown
Member

@markshannon markshannon Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need bumping again

Copy link
Copy Markdown
Contributor Author

@NekoAsakura NekoAsakura Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I already bumped it. Current upstream HEAD:

cpython/Include/internal/pycore_magic_number.h

Line 312 in 4599335

#define PYC_MAGIC_NUMBER 3665

/* This is equivalent to converting PYC_MAGIC_NUMBER to 2 bytes
(little-endian) and then appending b'\r\n'. */
#define PYC_MAGIC_NUMBER_TOKEN \
Expand Down
54 changes: 27 additions & 27 deletions Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading