gh-145917: Add MIME types for TTC and Haptics formats#145918
gh-145917: Add MIME types for TTC and Haptics formats#145918hugovk merged 15 commits intopython:mainfrom
Conversation
|
@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? I would like for all three to be merged in before the beta cutoff. Apologies if I sound a bit pushy. |
There was a problem hiding this comment.
Could we maybe combine the list in one because both lists were authored by you?
There was a problem hiding this comment.
We then need to write „and gh …“
No problem! Overall looks pretty good to me, nice contributions, thanks! |
benediktjohannes
left a comment
benediktjohannes
left a comment
There was a problem hiding this comment.
Overall looking pretty good to me! I did not look up the correctness of the applications and the entrys in official databases, but I can‘t approve the changes either because of permissions, so from what I saw when having a look on it, this LGTM, thanks!
|
Please also fix Bullet list ends without a blank line; unexpected unindent |
benediktjohannes
left a comment
benediktjohannes
left a comment
There was a problem hiding this comment.
Just one nitpick
| @@ -0,0 +1,8 @@ | |||
| * Add the following to ``mimetypes``: | |||
There was a problem hiding this comment.
Hmm, I think that in this news entry (where it is not 3.15.rst) the „“ is not necessary because this file itself is considered to be one entry in a list and therefore the „“ is then added automatically, but I may be mistaken. This also needs to be changed in the other PRs please. And also the contributor statement and potentially other elements which were moved to the right (due to this change) might need to get back again, please. But I might be mistaken. Is there any unit test suggesting this change?
There was a problem hiding this comment.
By the way: The rest looks quite good to me from a Short Overview, thank You very much for contributing!
|
Thank you very much, looks great to me! |
|
(I have not checked all mime types for correctness (e.g. typing, …) but just had a overview look on the PR in general, but based on my short review, I think that this is nice!) |
|
Unforetunately, we got (at least one) failing Check, but this first one seems to be unrelated, but please also have a look lateron on the potentially failing Checks whether they Are related or not because I didn’t Check on Small things Like Syntax |
clin1234
requested review from
AlexWaygood,
FFY00,
JelleZijlstra,
ambv,
berkerpeksag,
emmatyping,
erlend-aasland,
gpshead,
kumaraditya303,
lysnikolaou,
pablogsal and
rhettinger
as code owners
|
@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? Finally got CI to not nag at me... |
hugovk
removed request for
a team,
AA-Turner,
FFY00,
JelleZijlstra,
ambv,
berkerpeksag,
emmatyping,
erlend-aasland,
gpshead,
kumaraditya303,
lysnikolaou,
pablogsal,
rhettinger and
vsajip
|
Will this be merged in before beta1, and can this still be merged in during the beta releases? |
|
Yes, we can merge this before b1, just one suggestion to make the NEWS a bit shorter. |
Documentation build overview
105 files changed ·
|
…ooGKx.rst Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
CI failure: I think the GH web editor has inserted the wrong CRLF line endings... Please could you edit locally and replace with the usual LF? |
|
Thanks! |
3 participants
Uh oh!
There was an error while loading. Please reload this page.