Deprecate putpixel value lists#9586
Open
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9584
putpixel()says thatvalueaccepts a list.Pillow/src/PIL/Image.py
Lines 2176 to 2178 in 4e0aeba
However, while this works for palette-based values, the issue has pointed out that it doesn't otherwise. When it calls
_getink,_getinkraises errors thatPillow/src/_imaging.c
Line 599 in 4e0aeba
We could change
_getinkto accept lists, but updating this common error message would mean thatpaste(),new()and ImageDrawinks should all then accept lists. It would seem simpler to accept that this is an outlier, and to preventputpixelfrom accepting lists as a value.Because this is working for palette-based colors, I suggest deprecating that functionality first.