Fix re.Scanner capturing group for Python 3.15 compatibility#258
Open
hrnciar wants to merge 1 commit intopydata:masterfrom
Open
Fix re.Scanner capturing group for Python 3.15 compatibility#258hrnciar wants to merge 1 commit intopydata:masterfrom
hrnciar wants to merge 1 commit intopydata:masterfrom
Conversation
Python 3.15 forbids capturing groups in re.Scanner lexicon patterns. Convert the capturing group to a non-capturing group in num_re. Assisted-by: Cursor
Contributor
|
I feel like we need a 3.15 Tox run, but I don't think that will likely be practical until October. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 97.60% 98.45% +0.84%
==========================================
Files 30 30
Lines 3096 3103 +7
Branches 591 676 +85
==========================================
+ Hits 3022 3055 +33
+ Misses 39 27 -12
+ Partials 35 21 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.15 forbids capturing groups in re.Scanner lexicon patterns. Convert the capturing group to a non-capturing group in num_re.
Assisted-by: Cursor