Skip to content

Fix GH-14481: realpath() and SplFileInfo::getRealPath inside Phar #21883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliaal wants to merge 1 commit into
base: master
Choose a base branch
from
+82 −0
Open

Fix GH-14481: realpath() and SplFileInfo::getRealPath inside Phar #21883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions ext/phar/tests/gh14481.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
--TEST--
GH-14481 (realpath() and SplFileInfo::getRealPath inside Phar)
--EXTENSIONS--
phar
--INI--
phar.readonly=0
--FILE--
<?php
$file = __DIR__ . DIRECTORY_SEPARATOR . 'gh14481.phar';
@unlink($file);

$phar = new Phar($file);
$phar->addFromString('inner.php', "<?php echo 'hi';");
$phar->setStub("<?php __HALT_COMPILER();");
unset($phar);

$existing = "phar://" . $file . "/inner.php";
$missing = "phar://" . $file . "/nope.php";

echo "realpath existing entry:\n";
var_dump(realpath($existing));

echo "realpath missing entry:\n";
var_dump(realpath($missing));

echo "SplFileInfo existing entry:\n";
var_dump((new SplFileInfo($existing))->getRealPath());

echo "SplFileInfo missing entry:\n";
var_dump((new SplFileInfo($missing))->getRealPath());

echo "PharFileInfo existing entry:\n";
var_dump((new PharFileInfo($existing))->getRealPath());

echo "RecursiveIteratorIterator entry:\n";
foreach (new RecursiveIteratorIterator(new Phar($file)) as $info) {
var_dump($info->getRealPath());
}

echo "plain-filesystem branch unaffected:\n";
var_dump(realpath(__FILE__) === __FILE__);
?>
--CLEAN--
<?php
@unlink(__DIR__ . DIRECTORY_SEPARATOR . 'gh14481.phar');
?>
--EXPECTF--
realpath existing entry:
string(%d) "phar://%sgh14481.phar/inner.php"
realpath missing entry:
bool(false)
SplFileInfo existing entry:
string(%d) "phar://%sgh14481.phar/inner.php"
SplFileInfo missing entry:
bool(false)
PharFileInfo existing entry:
string(%d) "phar://%sgh14481.phar/inner.php"
RecursiveIteratorIterator entry:
string(%d) "phar://%sgh14481.phar/inner.php"
plain-filesystem branch unaffected:
bool(true)
11 changes: 11 additions & 0 deletions ext/spl/spl_directory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,6 +1244,17 @@ PHP_METHOD(SplFileInfo, getRealPath)
filename = intern->file_name ? ZSTR_VAL(intern->file_name) : NULL;
}

if (filename) {
const char *path_to_open = filename;
php_stream_wrapper *wrapper = php_stream_locate_url_wrapper(filename, &path_to_open, 0);
if (wrapper && wrapper != &php_plain_files_wrapper && !wrapper->is_url && wrapper->wops && wrapper->wops->url_stat) {
php_stream_statbuf ssb;
if (wrapper->wops->url_stat(wrapper, path_to_open, PHP_STREAM_URL_STAT_QUIET, &ssb, NULL) == 0) {
RETURN_STRING(filename);
}
RETURN_FALSE;
}
}

if (filename && VCWD_REALPATH(filename, buff)) {
#ifdef ZTS
Expand Down
10 changes: 10 additions & 0 deletions ext/standard/file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2102,6 +2102,16 @@ PHP_FUNCTION(realpath)
Z_PARAM_PATH(filename, filename_len)
ZEND_PARSE_PARAMETERS_END();

const char *path_to_open = filename;
php_stream_wrapper *wrapper = php_stream_locate_url_wrapper(filename, &path_to_open, 0);
if (wrapper && wrapper != &php_plain_files_wrapper && !wrapper->is_url && wrapper->wops && wrapper->wops->url_stat) {
php_stream_statbuf ssb;
if (wrapper->wops->url_stat(wrapper, path_to_open, PHP_STREAM_URL_STAT_QUIET, &ssb, NULL) == 0) {
RETURN_STRINGL(filename, filename_len);
}
RETURN_FALSE;
}

if (VCWD_REALPATH(filename, resolved_path_buff)) {
if (php_check_open_basedir(resolved_path_buff)) {
RETURN_FALSE;
Expand Down
Loading