TW-3961: include grantID in get folders response#313
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=========================================
Coverage 82.47% 82.47%
Complexity 357 357
=========================================
Files 37 37
Lines 1027 1027
Branches 95 95
=========================================
Hits 847 847
Misses 121 121
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: TW-3961
Problem
Folder.idandFolder.grantIdwere declared as non-nullableStringwith no default value. When theselectquery parameter was used without including these fields, Moshithrew:
Fix
Added empty string defaults to both fields so Moshi falls back gracefully instead of crashing. Type remains
String(non-nullable) — no breaking change for existing consumers.Changes
Folder.kt—idandgrantIddefault to""FoldersTests.kt— 2 new serialization tests covering partial responses viaselectLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.