Skip to content

http: harden ClientRequest options merge#63082

Open
mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina:harden-http-client-option-bag
Open

http: harden ClientRequest options merge#63082
mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina:harden-http-client-option-bag

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented May 2, 2026

No description provided.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels May 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (c3dd52a) to head (4eb2155).
⚠️ Report is 147 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63082      +/-   ##
==========================================
+ Coverage   89.61%   89.64%   +0.03%     
==========================================
  Files         706      712       +6     
  Lines      219136   220498    +1362     
  Branches    41981    42277     +296     
==========================================
+ Hits       196376   197669    +1293     
+ Misses      14671    14664       -7     
- Partials     8089     8165      +76     
Files with missing lines Coverage Δ
lib/_http_client.js 97.43% <100.00%> (+<0.01%) ⬆️

... and 109 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina force-pushed the harden-http-client-option-bag branch from b535c66 to 4eb2155 Compare May 2, 2026 16:11
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants