src: improve memory management in ffi source#63071
Open
addaleax wants to merge 2 commits intonodejs:mainfrom
Open
src: improve memory management in ffi source#63071addaleax wants to merge 2 commits intonodejs:mainfrom
addaleax wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Anna Henningsen <anna@addaleax.net>
This brings the typical benefits of using `BaseObject`, such as a reduced risk of memory management pitfalls (e.g. accidental `v8::Global` recursive references) and diagnostic tracking. Signed-off-by: Anna Henningsen <anna@addaleax.net>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
juanarbol
approved these changes
May 1, 2026
addaleax
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63071 +/- ##
==========================================
- Coverage 91.48% 89.65% -1.84%
==========================================
Files 360 712 +352
Lines 151674 220514 +68840
Branches 23917 42277 +18360
==========================================
+ Hits 138763 197703 +58940
- Misses 12635 14662 +2027
- Partials 276 8149 +7873
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: use
unique_ptrfor ffi memory managementffi: make
FFIFunctionInfoaBaseObjectsubclassThis brings the typical benefits of using
BaseObject,such as a reduced risk of memory management pitfalls
(e.g. accidental
v8::Globalrecursive references)and diagnostic tracking.