Skip to content

tools: filter V8 scripts for build toolchain #63069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richardlau wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −0
Open

tools: filter V8 scripts for build toolchain #63069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions tools/make-v8.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,32 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
GN_COMPILER_OPTS="is_clang=true clang_base_path=\"/usr\" clang_use_chrome_plugins=false treat_warnings_as_errors=false use_custom_libcxx=false clang_version=\"${CLANG_VERSION}\""
GN_RUST_ARGS="rustc_version=\"${RUST_VERSION}\" rust_sysroot_absolute=\"/usr\" rust_bindgen_root=\"/usr\""
export RUSTC_BOOTSTRAP=1

# Filter out options supported in clang >= 20 when using clang 19.
if [ "${CLANG_VERSION}" -eq "19" ]; then
find build/ \( -name "*.gn" -o -name "*.gni" \) -exec sed -i \
-e '/-Wno-nontrivial-memcall/d' {} \;
fi
# Filter out compiler options not supported by non-nightly clang builds
if [ "${CLANG_VERSION}" -ge "19" ]; then
find build/ \( -name "*.gn" -o -name "*.gni" \) -exec sed -i \
-e '/-Wno-unsafe-buffer-usage-in-static-sized-array/d' \
-e '/-Wno-uninitialized-const-pointer/d' \
-e '/-Wno-unused-but-set-global/d' \
-e '/-fno-lifetime-dse/d' \
-e '/-fsanitize-ignore-for-ubsan-feature/d' \
-e '/-fdiagnostics-show-inlining-chain/d' {} \;
fi
# Patch to match libadler/libadler2 based on what is present.
LIBADLER=$(basename "$(find "$(rustc --print sysroot)/lib/rustlib/" -type f -name "libadler*")" | cut -d '-' -f 1) || true
case "$LIBADLER" in
libadler2) sed -i -e 's/"adler"/"adler2"/g' build/rust/std/BUILD.gn
;;
libadler) sed -i -e 's/"adler2"/"adler"/g' build/rust/std/BUILD.gn
;;
*) echo "Warning: unable to detect libadler/libadler2 (found ${LIBADLER})"
;;
esac
;;
*) GN_COMPILER_OPTS="treat_warnings_as_errors=false use_custom_libcxx=false" ;;
esac
Expand Down
Loading