Skip to content

chore: typos and ESLint items#2479

Open
nschonni wants to merge 8 commits intonodejs:mainfrom
nschonni:eslint-cleanup
Open

chore: typos and ESLint items#2479
nschonni wants to merge 8 commits intonodejs:mainfrom
nschonni:eslint-cleanup

Conversation

@nschonni
Copy link
Copy Markdown
Member

@nschonni nschonni commented May 1, 2026

Description

Fixes a few minor typos picked up by CSpell and ESLint, but doesn't add a setup to continully check since there isn't a lot of code churn in the repo.

Motivation and Context

Noticed a few nags in the VSCode window when I was working on the genMatrix changes for ARM builds, but didn't want to mix it in there.

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be "and" instead of "an" in the title?

For ESLint, there is no config stored in the repo, so there is no provision for making the linting reproducible.

I'd suggest as a separate enhancement to at least add instructions for linting with ESLint, and possibly also with other components, like a configuration / script / workflow, etc. to run linting reproducibly.

The changes themselves look good!

@nschonni nschonni changed the title chore: typos an ESLint items chore: typos and ESLint items May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants