chore: typos and ESLint items#2479
Open
nschonni wants to merge 8 commits intonodejs:mainfrom
Open
Conversation
MikeMcC399
approved these changes
May 2, 2026
Contributor
MikeMcC399
left a comment
There was a problem hiding this comment.
Should that be "and" instead of "an" in the title?
For ESLint, there is no config stored in the repo, so there is no provision for making the linting reproducible.
I'd suggest as a separate enhancement to at least add instructions for linting with ESLint, and possibly also with other components, like a configuration / script / workflow, etc. to run linting reproducibly.
The changes themselves look good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few minor typos picked up by CSpell and ESLint, but doesn't add a setup to continully check since there isn't a lot of code churn in the repo.
Motivation and Context
Noticed a few nags in the VSCode window when I was working on the genMatrix changes for ARM builds, but didn't want to mix it in there.
Testing Details
Example Output(if appropriate)
Types of changes
Checklist