Skip to content

Volume Mesh Support for Prism and Pyramid Cell Types. Fixes #337#353

Merged
nmwsharp merged 17 commits intonmwsharp:masterfrom
mgsutton:mgs/prismsAndPyramids
May 3, 2026
Merged

Volume Mesh Support for Prism and Pyramid Cell Types. Fixes #337#353
nmwsharp merged 17 commits intonmwsharp:masterfrom
mgsutton:mgs/prismsAndPyramids

Conversation

@mgsutton
Copy link
Copy Markdown
Contributor

@mgsutton mgsutton commented Aug 9, 2025

This PR tries to address this issue: #337

@mgsutton mgsutton changed the title Volume Mesh Support for Prism and Pyramid Cell Types Volume Mesh Support for Prism and Pyramid Cell Types. Fixes #337 Aug 11, 2025
@mgsutton
Copy link
Copy Markdown
Contributor Author

mgsutton commented Aug 11, 2025

@nmwsharp, please take a look at this when you have a chance and let me know what you think. For a simple test mesh comprising of a hex, two prisms, a pyramid and a tet, it produces results that look like this.
screenshot_000000

I've tried to update the docs here, at least for cpp: nmwsharp/polyscope-docs#18

@grindstm
Copy link
Copy Markdown

grindstm commented Apr 1, 2026

I am highly interested in this feature. Is further contribution needed?

@mgsutton
Copy link
Copy Markdown
Contributor Author

Just waiting on review/feedback.

@nmwsharp
Copy link
Copy Markdown
Owner

nmwsharp commented May 3, 2026

Hi, thanks for this and pardon the slow response, looking into it a bit now.

One immediate question: I see that computeConnectivityData() now has a keyed set detecting "real" edges, but it's not clear to me why this is necessary.

@nmwsharp
Copy link
Copy Markdown
Owner

nmwsharp commented May 3, 2026

(fyi I may just push directly to this branch to resolve things and get it merged if I see obvious solutions to small problems)

@nmwsharp nmwsharp merged commit dcbaedb into nmwsharp:master May 3, 2026
10 checks passed
@nmwsharp
Copy link
Copy Markdown
Owner

nmwsharp commented May 3, 2026

Merged! Note that I changed the indexing on the prism type from your version, because I felt it was inconsistent with the others. (The others all had a "bottom" face that is clockwise-inward wound).

Let me know if anything doesn't seem right. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants