-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore(deps): bump the github-actions group across 1 directory with 10 updates #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/github_actions/github-actions-4210587ac8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The trailing comment
# v7is stale — per the PR description this SHA corresponds topeter-evans/create-pull-requestv8.1.1, so it's now off by a full major version. Dependabot likely skipped updating it because the bare# v7doesn't match its expected# vX.Y.Zformat (note it correctly updated# v7.2.1→# v8.1.0for setup-uv in this same file). Since this line is being touched anyway, consider correcting it to# v8.1.1so dependabot keeps it in sync going forward.Extended reasoning...
What's wrong
Line 32 of
.github/workflows/weekly-lockfile-update.ymlis updated to:The PR description explicitly states this bumps
peter-evans/create-pull-requestfrom 8.1.0 to 8.1.1, so SHA5f6978fa…is v8.1.1. The trailing# v7annotation is therefore wrong by a full major version.Why dependabot didn't fix it
Dependabot updates trailing version comments when they match its expected exact-version format. Evidence from this very file: on line 19 it correctly rewrote
# v7.2.1→# v8.1.0forastral-sh/setup-uv. But# v7is a bare major-version tag that doesn't match that pattern, so dependabot left it untouched while updating the SHA. The mismatch was already present before this PR (the old SHAc0f553fe…was v8.1.0 with the same# v7comment), and dependabot has now carried it forward again.Why it's worth flagging here
The whole point of the
# vX.Y.Zannotation next to a SHA pin is to give humans a readable indicator of which version is in use without having to resolve the hash. A comment that saysv7while the SHA isv8.1.1actively misleads reviewers — for example, someone auditing whether the repo is affected by a v7-only CVE, or checking whether a v8 feature is available, would draw the wrong conclusion. Every other action pin touched by this PR has an accurate exact-version comment (# v6.0.2,# v8.1.0,# v9.0.0,# v5.0.5, etc.), so this one is inconsistent with the rest of the diff.Step-by-step
peter-evans/create-pull-request@c0f553fe… # v7(actually v8.1.0 — already stale).5f6978fa….# v8.1.0to replace;# v7doesn't match, so it's preserved verbatim.peter-evans/create-pull-request@5f6978fa… # v7— SHA says v8.1.1, comment says v7.Addressing the counter-argument
One could argue this is intentional shorthand, similar to
# release/v1used forpypa/gh-action-pypi-publishinpublish-pypi.yml. However,# release/v1annotates a SHA that genuinely tracks therelease/v1branch tip — the comment matches what's pinned. Here,# v7does not match what's pinned (the SHA is on the v8 line), so it isn't a tracking-ref shorthand; it's simply stale. And because the bare-major format prevents dependabot from ever auto-correcting it, it will drift further on every future bump unless fixed manually.Impact & fix
Zero functional impact — the workflow runs the correct v8.1.1 code regardless of the comment — hence nit severity. But since this PR already modifies the line, it's the natural place to correct it:
Using the exact-version format also lets dependabot maintain it automatically on subsequent bumps.