Skip to content

Fix test_shim_integration: write aliases to /etc/bash.bashrc by setting remoteUser to root#115

Merged
markphip merged 2 commits intomainfrom
copilot/fix-test-scenarios-artifacts-helper
Apr 28, 2026
Merged

Fix test_shim_integration: write aliases to /etc/bash.bashrc by setting remoteUser to root#115
markphip merged 2 commits intomainfrom
copilot/fix-test-scenarios-artifacts-helper

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 28, 2026

mcr.microsoft.com/devcontainers/base:ubuntu advertises vscode as its default remote user via image metadata. Without an explicit remoteUser, the devcontainer CLI infers _REMOTE_USER=vscode, causing install.sh to set INSTALL_WITH_SUDO=true and write shell function aliases to /home/vscode/.bashrc instead of /etc/bash.bashrc. All six alias-related assertions in test_shim_integration.sh check /etc/bash.bashrc, so they all fail.

Changes

  • test/artifacts-helper/scenarios.json: Add "remoteUser": "root" to the test_shim_integration scenario, ensuring _REMOTE_USER=rootINSTALL_WITH_SUDO=false → aliases written to /etc/bash.bashrc.
"test_shim_integration": {
    "image": "mcr.microsoft.com/devcontainers/base:ubuntu",
    "remoteUser": "root",   // <-- added
    "features": { ... }
}

This mirrors the existing pattern: test_non_root_install explicitly sets "remoteUser": "vscode" to test the non-root path; test_shim_integration should explicitly set "remoteUser": "root" to test the root/system-wide path.

Copilot AI changed the title [WIP] Fix the failing GitHub Actions job test-scenarios (artifacts-helper) Fix test_shim_integration: write aliases to /etc/bash.bashrc by setting remoteUser to root Apr 28, 2026
Copilot AI requested a review from markphip April 28, 2026 14:11
@markphip markphip marked this pull request as ready for review April 28, 2026 14:14
@markphip markphip merged commit a026ce9 into main Apr 28, 2026
6 checks passed
@markphip markphip deleted the copilot/fix-test-scenarios-artifacts-helper branch April 28, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants