Skip to content

Add idea 2026.1 to GitHub workflow#260

Merged
filiphr merged 9 commits intomapstruct:mainfrom
hduelme:add-idea-2026.1-to-github-workflow
May 2, 2026
Merged

Add idea 2026.1 to GitHub workflow#260
filiphr merged 9 commits intomapstruct:mainfrom
hduelme:add-idea-2026.1-to-github-workflow

Conversation

@hduelme
Copy link
Copy Markdown
Contributor

@hduelme hduelme commented May 1, 2026

I added IDEA2026.1 to the GitHub workflow.
For this I upgraded the org.jetbrains.intellij.platform plugin to 2.15.0. This makes the workaround for older versions of idea obsolete.
In addition I replaced testFramework( TestFrameworkType.Bundled.INSTANCE ) (should not be used see https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-types.html#TestFrameworkType-Platform) with testFramework(TestFrameworkType.Plugin.Java.INSTANCE). As a reference I used github.com/JetBrains/intellij-sdk-code-samples/blob/main/simple_language_plugin/build.gradle.kts

Copy link
Copy Markdown
Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hduelme. This looks clean. I've left one small comment. By the way looking now at all the versions we test with, I think we need to drop 2024 and use 2025.1 as a minimum.

Comment thread .github/workflows/main.yml Outdated
@hduelme
Copy link
Copy Markdown
Contributor Author

hduelme commented May 2, 2026

@filiphr good catch. I removed the duplicated version.
I agree currently we test against lost of versions. As you suggested, I upgraded sinceBuild to idea 2025.1.

@filiphr filiphr merged commit 00e247f into mapstruct:main May 2, 2026
6 checks passed
@filiphr
Copy link
Copy Markdown
Member

filiphr commented May 2, 2026

Awesome. Thanks @hduelme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants