[Docs] Fix Meshery design embed using Hugo shortcode#996
[Docs] Fix Meshery design embed using Hugo shortcode#996gitAash wants to merge 6 commits intolayer5io:masterfrom
Conversation
Signed-off-by: gitAash <aashraya16bhat@gmail.com>
Signed-off-by: gitAash <aashraya16bhat@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces a static image with an embedded design flow and updates the formatting of alert components. The reviewer identified that the transition from Hugo shortcodes to tags is incompatible with the project's rendering logic and recommended reverting to the standard shortcode syntax to ensure the content is processed correctly.
…ccount.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Aashraya Bhat <153607773+gitAash@users.noreply.github.com>
…ccount.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Aashraya Bhat <153607773+gitAash@users.noreply.github.com>
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-996/
|
|
LGTM! |
Bhumikagarggg
added
the
issue/dco
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
4 participants
Notes for Reviewers
Updated the design embedding by exporting the Kanvas design as a JavaScript file,
adding it to static/export-designs/, and replacing the raw HTML
element with the Hugo shortcode as suggested in the previous review.
Addresses feedback from #864
Signed commits