Skip to content

refactor: use the built-in max/min to simplify the code#2966

Merged
aldas merged 1 commit intolabstack:masterfrom
criciss:master
May 2, 2026
Merged

refactor: use the built-in max/min to simplify the code#2966
aldas merged 1 commit intolabstack:masterfrom
criciss:master

Conversation

@criciss
Copy link
Copy Markdown
Contributor

@criciss criciss commented May 2, 2026

In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.

Signed-off-by: criciss <cricis@msn.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (b12f646) to head (01b45be).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
+ Coverage   93.08%   93.17%   +0.09%     
==========================================
  Files          43       43              
  Lines        4510     4501       -9     
==========================================
- Hits         4198     4194       -4     
+ Misses        195      189       -6     
- Partials      117      118       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit 7d1fed0 into labstack:master May 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants