Skip to content

[VC-52458] Support both number and string for tsgID#798

Open
inteon wants to merge 1 commit intomasterfrom
tsgID_number_or_string
Open

[VC-52458] Support both number and string for tsgID#798
inteon wants to merge 1 commit intomasterfrom
tsgID_number_or_string

Conversation

@inteon
Copy link
Copy Markdown
Contributor

@inteon inteon commented May 2, 2026

Based on feedback, this change updates tsgID to accept both numbers and strings.
Previously, the Helm chart’s values.schema.json enforced tsgID as a string. However, this constraint introduced unnecessary friction for users during initial setup.
To improve the user experience, we now allow both numeric and string inputs. As a side effect, this adds some complexity to the chart implementation, requiring a workaround for a Helm issue related to scientific notation handling.

context: in #793 we enforced tsgID to be a string

$ helm template ./deploy/charts/discovery-agent \
    --set config.tsgID=111111111111111111111111 \
    --set config.clusterName=aaa | grep 1111
            - "111111111111111111111111"

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon changed the title Support both number and string for tsgID [VC-52458] Support both number and string for tsgID May 2, 2026
@inteon inteon added test-e2e To signal e2e test job to be run test-ngts test-ark labels May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-ark test-e2e To signal e2e test job to be run test-ngts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant