Skip to content

feat(web): video player i18n#28192

Open
meesfrensel wants to merge 1 commit intomainfrom
feat/video-player-i18n
Open

feat(web): video player i18n#28192
meesfrensel wants to merge 1 commit intomainfrom
feat/video-player-i18n

Conversation

@meesfrensel
Copy link
Copy Markdown
Collaborator

Description

Follow-up PR to the custom video player. This is not the solution we wanted, but the media-chrome team is not interested in weblate or adding many languages in one go (see muxinc/media-chromenumber#1290), so adding the strings to our own weblate translations is an alternative solution.

I copied over the existing translations they have upstream.

Upsides of the specific implementation of spreading ...En (the english strings) and then overriding some of them:

  • We only translate the strings that we need
  • If new strings are added upstream, we don't get type errors (because those new keys are missing from the object)

Downsides:

  • If new strings are added upstream, we won't know unless we actively check all releases for this, or get a report of missing translations after an Immich release.

How Has This Been Tested?

Change to all these languages, and another one (fallback remains english)

  • Check strings are translated
  • Check strings fit within their containers (needed to change the settings menu to min-w to fit long German words)
English German
image image

Please describe to which degree, if any, an LLM was used in creating this pull request.

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant