feat(web): video player i18n#28192
Open
meesfrensel wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR to the custom video player. This is not the solution we wanted, but the media-chrome team is not interested in weblate or adding many languages in one go (see muxinc/media-chromenumber#1290), so adding the strings to our own weblate translations is an alternative solution.
I copied over the existing translations they have upstream.
Upsides of the specific implementation of spreading
...En(the english strings) and then overriding some of them:Downsides:
How Has This Been Tested?
Change to all these languages, and another one (fallback remains english)
min-wto fit long German words)Please describe to which degree, if any, an LLM was used in creating this pull request.
None