chore(bqjdbc): switch connection identifier to UUID#12957
Merged
keshavdandeva merged 6 commits intomainfrom May 4, 2026
Merged
chore(bqjdbc): switch connection identifier to UUID#12957keshavdandeva merged 6 commits intomainfrom
keshavdandeva merged 6 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BigQueryJdbcMdc class to use UUIDs instead of a sequential AtomicLong for generating connection IDs. This change ensures more robust unique identification for JDBC connections when a specific ID is not provided. I have no feedback to provide.
Neenu1995
reviewed
Apr 30, 2026
Neenu1995
approved these changes
Apr 30, 2026
logachev
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/507856382
Changes
BigQueryConnectionUUID.randomUUID().toString()as theconnectionId.BigQueryJdbcMdcBQ-JDBC-to the fullUUIDfor thread context logging.PerConnectionFileHandlerUUIDfromBQ-JDBC-prefix and constructs log filenames with the format:BQ-JDBC-yyyyMMddHHmmss-<first-4-chars-of-UUID>.log.Tests
BigQueryJdbcMdcTestto match the new prefix.PerConnectionFileHandlerTestto use a helper method for finding dynamic log files, making tests cleaner.