Skip to content

fix(openai): Only finish relevant spans in Chat Completions patches #6190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 6 commits into from
May 5, 2026
Merged

fix(openai): Only finish relevant spans in Chat Completions patches #6190

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a073290
ref(openai): Separate sync and async Completions patches
alexander-alderman-webb May 4, 2026
5114533
ref(openai): Separate sync and async Responses patches
alexander-alderman-webb May 4, 2026
d49cfac
ref(openai): Separate sync and async embeddings patches
alexander-alderman-webb May 4, 2026
f79b635
fix(openai): Only finish relevant spans in Completions patches
alexander-alderman-webb May 4, 2026
652d6fe
merge master
alexander-alderman-webb May 5, 2026
e6e1edf
.
alexander-alderman-webb May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sentry_sdk/integrations/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,8 @@ def _new_sync_chat_completion(f: "Any", *args: "Any", **kwargs: "Any") -> "Any":
except Exception as exc:
exc_info = sys.exc_info()
with capture_internal_exceptions():
_capture_exception(exc)
_capture_exception(exc, manual_span_cleanup=False)
span.__exit__(None, None, None)
reraise(*exc_info)

# Attribute check to fail gracefully if the attribute is not present in future `openai` versions.
Expand Down Expand Up @@ -776,7 +777,8 @@ async def _new_async_chat_completion(f: "Any", *args: "Any", **kwargs: "Any") ->
except Exception as exc:
exc_info = sys.exc_info()
with capture_internal_exceptions():
_capture_exception(exc)
_capture_exception(exc, manual_span_cleanup=False)
span.__exit__(None, None, None)
reraise(*exc_info)

# Attribute check to fail gracefully if the attribute is not present in future `openai` versions.
Expand Down
Loading