feat(cloudflare): Support tracing for queue producer#20529
Open
feat(cloudflare): Support tracing for queue producer#20529
Conversation
JPeer264
force-pushed
the
jp/cloudflare-queues
branch
from
ef6442b to
b9b0533
Compare
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b9b0533. Configure here.
| const totalBodySize = messageArray.reduce<number>((acc, m) => { | ||
| const size = getBodySize(m.body); | ||
| return size === undefined ? acc : acc + size; | ||
| }, 0); |
There was a problem hiding this comment.
sendBatch reports body size 0 instead of undefined
Low Severity
The sendBatch body size calculation uses reduce with an initial value of 0, so totalBodySize is always a number (minimum 0). When all messages have unsizable bodies (e.g., null or circular references), totalBodySize will be 0 and messaging.message.body.size gets set to 0. This is inconsistent with send, which correctly passes undefined from getBodySize when the body can't be sized, causing the attribute to be omitted. The sendBatch path emits a misleading 0 instead.
Reviewed by Cursor Bugbot for commit b9b0533. Configure here.
Contributor
|
👋 @mydea, @logaretm, @andreiborza — Please review this PR when you get a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14387
closes JS-1813
We already had support for the consumer, but the producer was never instrumented. Which means we only knew when a queue was consumed, but never when it was produced.
Example trace (producer new): https://sentry-sdks.sentry.io/explore/traces/trace/7ee71fd6dc8b4ce1a22b1bb9f9610b26/
Example trace (consumer): https://sentry-sdks.sentry.io/explore/traces/trace/486eb86cd02146279c4d547efb4cabab/
In
wrangler.jsonca producer needs to be configured viaqueues.producers:{ "queues": { "producers": [ { "queue": "test-queue", "binding": "MY_QUEUE", }, ], }, }Once this happens the
MY_QUEUEis available in theenvvariable, which we already instrument. With that we only addisQueueinsideinstrumentEnv.tsand get instrument the producer:Additional info
We are using
messaging.batch.message_count, which is not yet in our semantic conventions: https://getsentry.github.io/sentry-conventions/attributes/messaging/But it was already used before in our queue consumer logic. So the only thing is that it needs to be added first: getsentry/sentry-conventions#338 to make it official