Skip to content

Fix skip site-packages for web packaging #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FeodorFitsner merged 2 commits into from
May 2, 2026
Merged

Fix skip site-packages for web packaging #199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9445f96
Unify site-packages handling and copy for Pyodide
FeodorFitsner Mar 6, 2026
eb0bf8d
Copy site-packages for Pyodide only when needed
FeodorFitsner Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions src/serious_python/bin/package_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,23 +260,20 @@ class PackageCommand extends Command {
await cleanupDir(tempDir, allJunkFiles);
}

// install requirements
if (requirements.isNotEmpty && !skipSitePackages) {
String? sitePackagesRoot;

if (platform != "Pyodide") {
if (Platform.environment
.containsKey(sitePackagesEnvironmentVariable)) {
sitePackagesRoot =
Platform.environment[sitePackagesEnvironmentVariable];
}
if (sitePackagesRoot == null || sitePackagesRoot.isEmpty) {
sitePackagesRoot = path.join(currentPath, "build", "site-packages");
}
} else {
sitePackagesRoot = path.join(tempDir.path, defaultSitePackagesDir);
// site-packages root
String sitePackagesRoot =
path.join(currentPath, "build", "site-packages");
if (Platform.environment
.containsKey(sitePackagesEnvironmentVariable)) {
final envValue =
Platform.environment[sitePackagesEnvironmentVariable];
if (envValue != null && envValue.isNotEmpty) {
sitePackagesRoot = envValue;
}
}

// install requirements
if (requirements.isNotEmpty && !skipSitePackages) {
if (await Directory(sitePackagesRoot).exists()) {
await for (var f in Directory(sitePackagesRoot)
.list()
Expand Down Expand Up @@ -432,6 +429,21 @@ class PackageCommand extends Command {
}
}

// copy site packages to temp dir for web platform
if (platform == "Pyodide" && requirements.isNotEmpty) {
final sitePackagesSrcDir = Directory(sitePackagesRoot);
if (await sitePackagesSrcDir.exists()) {
stdout.writeln("Copying site packages to app archive");
final webPkgDir =
Directory(path.join(tempDir.path, defaultSitePackagesDir));
if (!await webPkgDir.exists()) {
await webPkgDir.create(recursive: true);
}
await copyDirectory(
sitePackagesSrcDir, webPkgDir, sitePackagesSrcDir.path, []);
}
}

// create archive
stdout.writeln(
"Creating app archive at ${dest.path} from a temp directory");
Expand Down
Loading