Skip to content

Fix unmatched select size value handling#36387

Open
raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601:codex/select-size-unmatched-value
Open

Fix unmatched select size value handling#36387
raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601:codex/select-size-unmatched-value

Conversation

@raashish1601
Copy link
Copy Markdown

Summary

Fixes #24469.

When a controlled single-select has size > 1 and its value does not match any option, React should leave the select with no selected option instead of selecting the first non-disabled option. This matches the browser behavior React already preserves for initially rendered listbox-style selects.

How did you test this change?

  • corepack yarn test ReactDOMSelect-test
  • corepack yarn test --prod ReactDOMSelect-test
  • corepack yarn prettier
  • corepack yarn linc
  • ./node_modules/.bin/flow.cmd status with the generated dom-browser Flow config

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 2, 2026

Hi @raashish1601!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@raashish1601 raashish1601 marked this pull request as ready for review May 2, 2026 04:45
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 2, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: <select size value> with value not matching any option results in first option being selected

1 participant