Fix unmatched select size value handling#36387
Fix unmatched select size value handling#36387raashish1601 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @raashish1601! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Fixes #24469.
When a controlled single-select has
size > 1and itsvaluedoes not match any option, React should leave the select with no selected option instead of selecting the first non-disabled option. This matches the browser behavior React already preserves for initially rendered listbox-style selects.How did you test this change?
corepack yarn test ReactDOMSelect-testcorepack yarn test --prod ReactDOMSelect-testcorepack yarn prettiercorepack yarn linc./node_modules/.bin/flow.cmd statuswith the generateddom-browserFlow config