Add allowsKeyboardScrolling prop to ScrollView for scrolling its content with hardware keyboard input#56671
Open
ArturKalach wants to merge 2 commits intofacebook:mainfrom
Open
Conversation
allowsKeyboardScrolling prop to ScrollView for native api support
allowsKeyboardScrolling prop to ScrollView for native api supportallowsKeyboardScrolling prop to ScrollView for native API support
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
allowsKeyboardScrolling prop to ScrollView for native API supportallowsKeyboardScrolling prop to ScrollView for scrolling its content with hardware keyboard input
7e9d145 to
34e2fc4
Compare
a28b1ea to
2659326
Compare
2659326 to
43851f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Apple introduced allowsKeyboardScrolling at WWDC 2023 (session 10281) — a UIScrollView property that enables scroll views to respond to Page Up, Page Down, Home, and End keys on iPad and iPhone.
React Native currently has no support for this property, leaving users on iOS 17+ without the expected keyboard navigation behavior. This was reported by @filip-angelov in #52833.
This PR enables allowsKeyboardScrolling by default for devices running iOS 17.0+, bringing React Native scroll behavior in line with native UIKit defaults and improving the experience for users with external keyboards.
Changelog:
[IOS] [ADDED] - Add
allowsKeyboardScrollingprop to ScrollView to allows scrolling its content with hardware keyboard inputTest Plan:
ScrollViewon a device running iOS 17 or later.allowsKeyboardScrolling={false}and verify that keyboard scrolling is disabled.