Fix several issues with string literal detection#351
Merged
LagoLunatic merged 5 commits intoencounter:mainfrom May 4, 2026
Merged
Fix several issues with string literal detection#351LagoLunatic merged 5 commits intoencounter:mainfrom
LagoLunatic merged 5 commits intoencounter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #321 that caused pooled strings to be decoded incorrectly. Also adds support for detecting MSVC
`string'literals as being strings.Now ASCII, SJIS, and UTF16-BE are known to work for sure and have test cases. Other encodings like EUC-JP and Big5 may work but haven't been properly tested. MWCC's nonstandard SJIS wide strings still do not work.