Fix: importOrder() with single catch-all group strips blank lines added by greclipse(), causing non-idempotent formatting#2914
Open
austek wants to merge 2 commits intodiffplug:mainfrom
Open
Conversation
austek
added a commit
to austek/spotless
that referenced
this pull request
May 1, 2026
…plug#2914) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
28edf92 to
0c25202
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importOrder()with no explicit groups (single catch-all) unconditionally replaced the entire import block, stripping any blank lines that a prior step likegreclipse()had independently inserted between import groups.greclipse()adds blank lines →importOrder()strips them →greclipse()re-adds them → repeat (GitHub issue Maven Groovy importOrder prevents greclipse from checking and applying #899).Test plan
groovyImportsPreservesBlankLinesBetweenGroups— asserts thatimportOrder()with no args leaves an already-sorted Groovy import block with blank lines untouched.groovySortImportsStripsInterleavedBlankLines— asserts that sorting still works when imports are out of order; interleaved blank lines are removed as a side effect of the rewrite.Fixes #899