feat: allow subsets of dtypes, allow device-dependent dtype support#1005
Open
ev-br wants to merge 2 commits intodata-apis:mainfrom
Open
feat: allow subsets of dtypes, allow device-dependent dtype support#1005ev-br wants to merge 2 commits intodata-apis:mainfrom
ev-br wants to merge 2 commits intodata-apis:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in gh-998 and the community meeting on Apr 30th,
dtype=..., device=...raise an exception + specify that creation functions should raise. Note that this still leavesastypeandto_deviceonly implicitly specified and only covered by the recommendation to raise.__getitem__and__setitem__are implementation-defined (and presumably covered by the recommendation to raise).