Refresh Python quickstart for Python 3.12#142
Open
dex-the-ai wants to merge 2 commits intomainfrom
Open
Conversation
Author
|
Owner ping for this maintenance PR: @nithishr Requesting review from the manifest-listed owner(s) where GitHub does not already show a pending review request. |
There was a problem hiding this comment.
Code Review
This pull request upgrades the project to Python 3.12, updates the Docker base image to python:3.12-slim-bookworm, and bumps the flask_restx dependency to version 1.3.2. The documentation has been updated to reflect the new version requirements and now uses python3 in command examples. Feedback was provided regarding the switch to python3 in the README, noting that it reduces cross-platform compatibility for Windows users and introduces inconsistencies with other commands in the document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flask_restxfrom 1.3.0 to 1.3.2python3invocation consistentlyVerification
cd src && uv venv --seed --python 3.12.13 .venv && source .venv/bin/activate && uv pip install -r requirements.txtcd src && source .venv/bin/activate && python -m pytest✅ (47 passedwith the app running locally on Python 3.12.13)cd src && source .venv/bin/activate && python app.py✅curl http://127.0.0.1:8080/✅ Swagger root served locallycurl -X POST http://127.0.0.1:8080/api/v1/airport/airport_walkthrough_20260501 ...✅ create/read/delete walkthrough passedcurl "http://127.0.0.1:8080/api/v1/airline/to-airport?airport=SFO&limit=2"✅curl "http://127.0.0.1:8080/api/v1/hotel/autocomplete?name=Ritz"✅cd src && docker build -t python-quickstart:py312 .✅Evidence
travel-samplebucket.src/requirements.txt:flask-restx1.3.0 -> 1.3.2.pytest output
API walkthrough excerpt
tutorial-maintenance/runs/python-quickstart/2026-05-01T163641/verification.mdtutorial-maintenance/runs/python-quickstart/2026-05-01T163641/walkthrough-curl.txttutorial-maintenance/runs/python-quickstart/2026-05-01T163641/docker-build.logNotes
pyteststill assumes the Flask app is already running; I did not change that repo behavior in this PR because it is pre-existing and reflected in the current workflow.