feat: add database transaction state check#10152
Open
memleakd wants to merge 1 commit intocodeigniter4:4.8from
Open
feat: add database transaction state check#10152memleakd wants to merge 1 commit intocodeigniter4:4.8from
memleakd wants to merge 1 commit intocodeigniter4:4.8from
Conversation
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
ddevsr
approved these changes
May 2, 2026
patel-vansh
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes adding
inTransaction()to database connections so code can check whether the connection is currently inside an active CodeIgniter-managed transaction.The method provides a small public API for transaction state without exposing transaction depth or requiring userland code to rely on internal connection properties. This is useful for reusable services, libraries, and framework-adjacent integrations that need to adapt when they are called from inside an existing transaction.
For example, a package may need to decide whether to perform work immediately, join caller-managed transactional behavior, or defer side effects through transaction callbacks.
Behavior
truewhile the connection is inside a CodeIgniter-managed transaction.falsewhen no CodeIgniter-managed transaction is active.falsewhen transactions are disabled.falseinsideafterCommit()andafterRollback()callbacks because the transaction has already reached its terminal state.This is intentionally a boolean state check only. It does not expose the transaction depth, and it reflects transactions started through CodeIgniter’s transaction APIs rather than raw SQL or driver-specific transaction handling.
This adds
inTransaction()toConnectionInterface, so custom implementations will need to add the new method. The changelog lists this under interface changes.Checklist: