fix(controlplane): tolerate orphaned project memberships in ListMembers#3083
Merged
migmartri merged 1 commit intochainloop-dev:mainfrom Apr 30, 2026
Merged
Conversation
ProjectRepo.ListMembers now skips membership rows whose user/group no longer exists instead of returning 404, and decrements totalCount accordingly. memberships.member_id is polymorphic with no FK, so deletes that bypass the app-level cascade can leave dangling rows. Includes a one-shot migration that removes existing orphans. Closes chainloop-dev#3082 Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jiparis
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectRepo.ListMembersnow skips membership rows whose referenced user or group no longer exists instead of failing the whole call with a 404, and decrementstotalCountper skipped row so the UI sees a consistent total.20260430223706.sql) that removes existing orphanedmembershipsrows for both user and group membership types.Background
memberships.member_idis polymorphic and has no foreign key tousers/groups. When a user or group is deleted via a path that bypassesMembershipRepo.Delete(e.g. SQL cascade triggered by the legacyuser_membershipsFK onUser.Delete), the project-level membership rows survive as orphans. A single orphan causedListMembersto return HTTP 404, hiding all members of the affected project from the UI.Closes #3082