fix(py_binary): include runfiles.symlinks/root_symlinks in python_zip_file#3750
Open
TvdW wants to merge 1 commit intobazel-contrib:mainfrom
Open
fix(py_binary): include runfiles.symlinks/root_symlinks in python_zip_file#3750TvdW wants to merge 1 commit intobazel-contrib:mainfrom
TvdW wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that runfiles.symlinks and runfiles.root_symlinks are correctly included in the python_zip_file output group, which fixes issues with certain data dependencies (e.g., sh_binary under Bazel 9). The implementation updates the zip manifest generation logic and includes a new test suite to verify the contents of the generated zip. Feedback focuses on optimizing the collection of symlink target files by using depsets instead of list concatenation to improve efficiency.
…_file The legacy zipapp manifest builder only iterated `runfiles.files`, silently dropping any entries contributed via `ctx.runfiles(symlinks=...)` or `ctx.runfiles(root_symlinks=...)`. This surfaced under bazel 9 / rules_shell 0.6 because `@bazel_tools//tools/bash/runfiles:runfiles` became an alias whose legacy path is exposed via a root_symlink, so sh_binary deps of py_binary failed to bootstrap from the produced zip with "cannot find bazel_tools/tools/bash/runfiles/runfiles.bash".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy zipapp manifest builder only iterated
runfiles.files, silently dropping any entries contributed viactx.runfiles(symlinks=...)orctx.runfiles(root_symlinks=...). This surfaced under bazel 9 / rules_shell 0.6 because@bazel_tools//tools/bash/runfiles:runfilesbecame an alias whose legacy path is exposed via a root_symlink, so sh_binary deps of py_binary failed to bootstrap from the produced zip with "cannot find bazel_tools/tools/bash/runfiles/runfiles.bash".