test: fix flaky test test_isolation_cookies for playwright crawler#1729
Merged
vdusek merged 4 commits intoapify:masterfrom May 5, 2026
Merged
test: fix flaky test test_isolation_cookies for playwright crawler#1729vdusek merged 4 commits intoapify:masterfrom
vdusek merged 4 commits intoapify:masterfrom
Conversation
Mantisus
force-pushed
the
flaky-playwright-cookies
branch
5 times, most recently
from
0a889e3 to
2c42bc1
Compare
vdusek
changed the title
test_playwright_crawler.py::test_isolation_cookies[without use_incognito_pages]test_playwright_crawler.py::test_isolation_cookies[without use_incognito_pages]
vdusek
changed the title
test_playwright_crawler.py::test_isolation_cookies[without use_incognito_pages]
Mantisus
force-pushed
the
flaky-playwright-cookies
branch
22 times, most recently
from
eebd6a1 to
cd4ade1
Compare
Mantisus
force-pushed
the
flaky-playwright-cookies
branch
8 times, most recently
from
8a9407c to
46700e3
Compare
Mantisus
force-pushed
the
flaky-playwright-cookies
branch
from
46700e3 to
9ddb787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hypothesis for the root cause: if Playwright runs slowly, the browser may be moved to the inactive list by
BrowserPool._identify_inactive_browsers()between requests. When a new context is opened, the assertion breaks, and the test fails.The fix increases the time interval during which the browser stays active.
Closes: #1651