Skip to content

Remove unused code #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ebyhr wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −6
Open

Remove unused code #3326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions pyiceberg/catalog/bigquery_metastore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ def create_table(

dataset_name, table_name = self.identifier_to_database_and_table(identifier)

dataset_ref = DatasetReference(project=self.project_id, dataset_id=dataset_name)
location = self._resolve_table_location(location, dataset_name, table_name)
provider = load_location_provider(table_location=location, table_properties=properties)
metadata_location = provider.new_table_metadata_file_location()
Expand Down Expand Up @@ -172,9 +171,7 @@ def create_namespace(self, namespace: str | Identifier, properties: Properties =
try:
dataset_ref = DatasetReference(project=self.project_id, dataset_id=database_name)
dataset = Dataset(dataset_ref=dataset_ref)
dataset.external_catalog_dataset_options = self._create_external_catalog_dataset_options(
self._get_default_warehouse_location_for_dataset(database_name), properties, dataset_ref
)
dataset.external_catalog_dataset_options = self._create_external_catalog_dataset_options(properties, dataset_ref)
self.client.create_dataset(dataset)
except Conflict as e:
raise NamespaceAlreadyExistsError("Namespace {database_name} already exists") from e
Expand All @@ -195,7 +192,6 @@ def load_table(self, identifier: str | Identifier) -> Table:
Raises:
NoSuchTableError: If a table with the name does not exist, or the identifier is invalid.
"""
database_name, table_name = self.identifier_to_database_and_table(identifier, NoSuchTableError)
dataset_name, table_name = self.identifier_to_database_and_table(identifier, NoSuchTableError)

try:
Expand Down Expand Up @@ -363,7 +359,7 @@ def _create_external_catalog_table_options(self, location: str, parameters: dict
)

def _create_external_catalog_dataset_options(
self, default_storage_location: str, metadataParameters: dict[str, Any], dataset_ref: DatasetReference
self, metadataParameters: dict[str, Any], dataset_ref: DatasetReference
) -> ExternalCatalogDatasetOptions:
return ExternalCatalogDatasetOptions(
default_storage_location_uri=self._get_default_warehouse_location_for_dataset(dataset_ref.dataset_id),
Expand Down
Loading