Examples: add measurement correction storyline DAGs (continuation of #61953)#66257
Open
andreahlert wants to merge 3 commits intoapache:mainfrom
Open
Examples: add measurement correction storyline DAGs (continuation of #61953)#66257andreahlert wants to merge 3 commits intoapache:mainfrom
andreahlert wants to merge 3 commits intoapache:mainfrom
Conversation
Signed-off-by: André Ahlert <andre@aex.partners>
Signed-off-by: André Ahlert <andre@aex.partners>
Address the static-check failures that left the original PR in draft: - replace from airflow import DAG / airflow.operators.python with the current locations (airflow.sdk.DAG and airflow.providers.standard. operators.python) so the operator example loads on Airflow 3.x; - apply ruff import sort and ruff format fixes flagged by prek; - ensure trailing newline on both files. Signed-off-by: André Ahlert <andre@aex.partners>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up #61953, which @Chandanakt opened in February for the measurement correction example DAG. The PR was marked as draft over static-check failures and got auto-closed by the bot a few weeks later when she didn't come back. Since #52482 is part of the Examples Refurbish epic and the storyline is going to need this DAG eventually, brought it back, rebased on main, and got the checks green.
Her two commits are preserved. On top I added one commit with the fixes that were needed to ship: ruff import order and format, trailing newlines, and replacing the deprecated
from airflow import DAG/airflow.operators.pythonimports with the currentairflow.sdk.DAG/airflow.providers.standard.operators.pythonpaths so the operator example actually loads on Airflow 3.x.Both DAGs parse cleanly and prek is fully green now. The original PR never got a maintainer review so this would be the first pass.
@jscheffl since you've been driving the Examples Refurbish epic, would you mind taking a look?
closes: #52482
Was generative AI tooling used to co-author this PR?