Skip to content

test(multiple): generate additional tests for angular-aria directives, harness and patterns#33162

Merged
adolgachev merged 7 commits intoangular:mainfrom
adolgachev:aria-tests
May 1, 2026
Merged

test(multiple): generate additional tests for angular-aria directives, harness and patterns#33162
adolgachev merged 7 commits intoangular:mainfrom
adolgachev:aria-tests

Conversation

@adolgachev
Copy link
Copy Markdown
Contributor

@adolgachev adolgachev commented Apr 28, 2026

Used Gemini to go through the Angular Aria components, harnesses and patterns to fill in a few additional harness methods and specs.

Of note is switching the shuffled tests back to test at the directive level instead of at the lower collection level (already tested in SortedCollection unit tests).

@adolgachev adolgachev force-pushed the aria-tests branch 5 times, most recently from 79437f6 to 3b6d1f6 Compare April 30, 2026 05:47
@adolgachev adolgachev added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2026
@adolgachev adolgachev force-pushed the aria-tests branch 5 times, most recently from 041446b to 3c0f6d6 Compare April 30, 2026 21:12
@adolgachev adolgachev marked this pull request as ready for review May 1, 2026 00:08
@pullapprove pullapprove Bot requested review from andrewseguin and crisbeto May 1, 2026 00:08
@adolgachev adolgachev marked this pull request as draft May 1, 2026 00:09
@adolgachev adolgachev force-pushed the aria-tests branch 5 times, most recently from b48cbe0 to d4eb3f2 Compare May 1, 2026 00:40
@adolgachev adolgachev marked this pull request as ready for review May 1, 2026 01:32
@adolgachev adolgachev added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 1, 2026
@adolgachev adolgachev requested review from ok7sai and tjshiu and removed request for andrewseguin May 1, 2026 04:53
@adolgachev adolgachev removed request for crisbeto and tjshiu May 1, 2026 18:04
@adolgachev adolgachev added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels May 1, 2026
@adolgachev adolgachev merged commit 619a53d into angular:main May 1, 2026
31 of 33 checks passed
@adolgachev
Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@adolgachev adolgachev deleted the aria-tests branch May 1, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants