Cache Maven Distributions downloaded by the Maven Wrapper

[yeikel]

Related issue : #448

With cache: https://github.com/yeikel/mvn-wrapper-caching-test/actions/runs/4158390216/jobs/7193735589

Without cache : https://github.com/yeikel/mvn-wrapper-caching-test/actions/runs/4158489501/jobs/7193751281

2023-02-12 22:15:22 (4.06 MB/s) - ‘/home/runner/work/mvn-wrapper-caching-test/mvn-wrapper-caching-test/.mvn/wrapper/maven-wrapper.jar’ saved [59925/59925]
[INFO] Apache Maven Wrapper 3.1.1
[INFO] Installing Maven distribution /home/runner/.m2/wrapper/dists/apache-maven-3.8.5-bin/67203e94
[INFO] Downloading https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.5/apache-maven-3.8.5-bin.zip
[INFO] Unzipping /home/runner/.m2/wrapper/dists/apache-maven-3.8.5-bin/67203e94/apache-maven-3.8.5-bin.zip to /home/runner/.m2/wrapper/dists/apache-maven-3.8.5-bin/67203e94

Cache invalidation after a maven upgrade : https://github.com/yeikel/mvn-wrapper-caching-test/actions/runs/4158550035/jobs/7193847666

[yeikel]

I am not sure why the "Check dist" is failing. Any help would be appreciated

C:\Users\Yeikel\setup-java>nvm list

• 16.19.0 (Currently using 64-bit executable)

C:\Users\Yeikel\setup-java>npm ci --ignore-scripts
npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

added 407 packages, and audited 408 packages in 4s

25 packages are looking for funding
run npm fund for details

found 0 vulnerabilities

C:\Users\Yeikel\setup-java>npm run build

setup-java@3.4.1 build
ncc build -o dist/setup src/setup-java.ts && ncc build -o dist/cleanup src/cleanup-java.ts

ncc: Version 0.33.4
ncc: Compiling file index.js into CJS
ncc: Using typescript@4.2.3 (local user-provided)
4165kB dist\setup\index.js
4165kB [6176ms] - ncc 0.33.4
ncc: Version 0.33.4
ncc: Compiling file index.js into CJS
ncc: Using typescript@4.2.3 (local user-provided)
2800kB dist\cleanup\index.js
2800kB [4451ms] - ncc 0.33.4

C:\Users\Yeikel\setup-java>git status
On branch cache/mvn-wrapper
Your branch is up to date with 'origin/cache/mvn-wrapper'.

nothing to commit, working tree clean

C:\Users\Yeikel\setup-java>

[IvanZosimov]

@yeikel, just tried to rebuild your solution locally on Windows, check the output out:

C:\Users\Desktop\Yeikel\setup-java> git status
On branch cache/mvn-wrapper
Your branch is up to date with 'origin/cache/mvn-wrapper'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   dist/cleanup/index.js
        modified:   dist/setup/index.js

no changes added to commit (use "git add" and/or "git commit -a")

Try to rebuild one more time.

[yeikel]

@yeikel, just tried to rebuild your solution locally on Windows, check the output out:

C:\Users\Desktop\Yeikel\setup-java> git status
On branch cache/mvn-wrapper
Your branch is up to date with 'origin/cache/mvn-wrapper'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   dist/cleanup/index.js
        modified:   dist/setup/index.js

no changes added to commit (use "git add" and/or "git commit -a")

Try to rebuild one more time.

It seems that there is a slight difference in how the compiler behaves in Windows compared to Unix

I tried the same build in my Windows machine and it returned no changes. But in my Mac it created 1ec9456

[yeikel]

@IvanZosimov Could you please approve the workflow? Hopefully after my latest commits there are no more conflicts

[mahabaleshwars]

Hey @yeikel,

The PR currently has merge conflicts due to base branch divergence.

Could you:

• Rebase onto the current main
• Rebuild the dist/ bundles
• Verify the tests still pass

Once the conflicts are resolved, this looks good to move forward with review.

[yeikel]

Hey @yeikel,

The PR currently has merge conflicts due to base branch divergence.

Could you:

* Rebase onto the current main

* Rebuild the dist/ bundles

* Verify the tests still pass

Once the conflicts are resolved, this looks good to move forward with review.

@mahabaleshwars I rebased it and ran npm run build on the latest build using node v24.14.1

The tests are also passing

Test Suites: 24 passed, 24 total
Tests:       744 passed, 744 total
Snapshots:   0 total
Time:        43.727 s